-
Notifications
You must be signed in to change notification settings - Fork 225
refactor(vulnfeeds): Uncouple Debian conversion from combine-to-osv converter #3894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two options here for the modified and published date.
-
Keep the existing architecture of outputting stuff to combine-to-osv, and just have that emit two records, DEBIAN-CVE and CVE-
-
Download the CVEs here as well (I think we mirror them to our own bucket already right? At least the NVD entries, so we can just download from that), and map them here.
I think option 2 is probably better here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, added some more comments!
deployment/clouddeploy/gke-workers/environments/oss-vdb-test/debian-cve-convert.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Starting to deal with #2465
Closes #3899