fix: alpine versions <=/>=
#3978
Merged
+78
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another-rex
approved these changes
Sep 17, 2025
| self.assertLess( | ||
| ecosystem.sort_key('13.0.14.5-r1'), ecosystem.sort_key('16.6-r0')) | ||
|
|
||
| # Check >= / <= methods: https://github.com/google/osv.dev/pull/3978 |
There was a problem hiding this comment.
Ah yes, the self referential PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alpine versions seem to be falling back to string comparisons for
>=/<=, which is wrong.This issue is in the univers code we've vendored, which seems to be a bit outdated, but it's still present on their current version
I've added tests to catch this in Alpine and other ecosystems, but APK seems to have been the only ecosystem affected.