ui: refactor display of args #3032
Conversation
Add a helper function to print the entire set of args at once as a JSON object, reusing existing functionality for exporting arg sets to json. This makes it easier to inspect arg sets at a glance and would enable simplifying the UI code by removing the logic which constructs arg tree in javascript.
Leverage the new print_args() function to avoid reconstructing the args tree in JS.
altimin
force-pushed
the
dev/altimin/print_args
branch
from
96c7193 to
0b5e8dc
Compare
altimin
force-pushed
the
dev/altimin/ui_args
branch
from
c57f6be to
36deba0
Compare
altimin
force-pushed
the
dev/altimin/print_args
branch
2 times, most recently
from
1f344a9 to
6d07d6e
Compare
There was a problem hiding this comment.
I think this looks very reasonable in general in terms of the UI side.
That said (and I realize that this PR in particular doesn't change much in this regard, apart from in the ftrace event details panel) but I'm not a huge fan of the fact that the query is abstracted behind the getArgs function.
I'd like to have the option to fetch everything in one go like:
SELECT
*,
print_args(arg_set_id) AS argsJson
FROM foo
Then have a synchronous helper to turn this into this into a tree of ArgDict for printing and processing.
In general the SQL helper functions like this usually end up pulling duplicate data and slowing things down. I'll concede that this args example is quite clean but I think as a general principle they should be avoided.
Again as this PR doesn't really change this much (apart from in the ftrace details panel), I think we can tackle this in a different PR, but I thought I'd mention it here.
Leverage the new print_args() function to avoid reconstructing the args tree in JS.
This change doesn't affect UX, just simplifies the code.