Upgrade to Gradle 7.6 and Java 11#800
Merged
ejona86 merged 4 commits intogoogle:masterfrom Feb 19, 2026
Merged
Conversation
omarismail94
force-pushed
the
upgradeOnly
branch
2 times, most recently
from
deaf902 to
1bfcd2f
Compare
- Update test matrices to include Gradle 8.x (up to 8.13) and AGP 8.x versions. - Refactor `assertJavaCompileHasProtoGeneratedDir` verification in test projects to be CC compatible with Gradle 8.13+ - Update CI workflows to use Java 17 to run tests that use AGP 8
omarismail94
force-pushed
the
upgradeOnly
branch
from
1bfcd2f to
fd90437
Compare
Contributor
Author
|
@ejona86 ready for review |
ejona86
reviewed
Feb 17, 2026
Collaborator
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Sending what I have. I need to stare at the assertJavaCompileHasProtoGeneratedDir changes longer.
omarismail94
force-pushed
the
upgradeOnly
branch
from
c56d7ce to
6138a10
Compare
ejona86
reviewed
Feb 18, 2026
omarismail94
force-pushed
the
upgradeOnly
branch
from
6138a10 to
42ec5ae
Compare
Move the verification logic into a static method within a ProtoVerifier class. This approach maintains the the use of local closures in test.doLast, and ensures compatibility with the Gradle Configuration Cache by capturing required task outputs as providers and avoiding directproject references during execution.
omarismail94
force-pushed
the
upgradeOnly
branch
from
42ec5ae to
25afca1
Compare
ejona86
approved these changes
Feb 19, 2026
Collaborator
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Looks good. Thank you so much.
Only one small change left. I'll merge after that is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assertJavaCompileHasProtoGeneratedDirverification in test projects to be CC compatible with Gradle 8.13+TESTED: Ran ./gradlew test and it passed
First step in fixing Issue #797