-
Notifications
You must be signed in to change notification settings - Fork 318
Include EDIT_SCOPE for initial setup. #11437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build files for cd5e3ce have been deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankitrox, this is looking good.
It would be nice to extend the test coverage a bit, please see my comments.
Also, please can you expand QAB to cover these scenarios?
- The user connects Analytics after the initial setup flow.
- The user already has Analytics connected, then enables the feature flag. In this case, the edit scope should not be requested when making requests to the Analytics API (e.g. loading reports on the dashboard).
@techanvil Thank you for reviewing the PR and providing the feedback. I've addressed the points you mentioned in the comments and also updated the QAB as per suggested scenarios. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankitrox, that's great. LGTM.
✅
Summary
Addresses issue:
analytics.edit
scope is included in the set of required scopes for the Analytics module. #11372Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist