Bug/11196 conversion tracking snapshoting #11485
Open
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2025 17:15
…state should be added to the snapshot.
…conversion tracking data.
|
Build files for 9cd400c are ready:
|
|
Size Change: +1.22 kB (+0.06%) Total Size: 1.98 MB ℹ️ View Unchanged
|
…on-tracking-snapshoting.
tofumatt
requested changes
Sep 19, 2025
| * @return {Object} The snapshot store object. | ||
| */ | ||
| export function createSnapshotStore( storeName ) { | ||
| export function createSnapshotStore( storeName, { pick: pickPaths } = {} ) { |
There was a problem hiding this comment.
Rather than using pick/pickPaths, can we have a more descriptive name for this argument? Calling it pick seems like the implementation detail of using lodash's pick() is bubbling up.
I'd call this keysToSnapshot or onlySnapshotKeys, etc. so it's a bit more clear to someone reading it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
pickas a string or an array of strings that are passed to lodash'spickfunction.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist