Add EDD Enhanced Conversions integration. #11486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +92 B (0%) Total Size: 2.01 MB ℹ️ View Unchanged
|
|
Build files for e5707f7 are ready:
|
abdelmalekkkkk
force-pushed
the
enhancement/11011-easy-digital-downloads-ecee-integration
branch
from
b2b034d to
6e4518b
Compare
abdelmalekkkkk
force-pushed
the
enhancement/11011-easy-digital-downloads-ecee-integration
branch
from
6e4518b to
5ee3661
Compare
hussain-t
requested changes
Oct 2, 2025
There was a problem hiding this comment.
Nice work, @abdelmalekkkkk! The changes look good. However, there are some feedback to be addressed before we merge.
We also need unit test coverage for the following methods, and we can mock the EDD methods if necessary:
register_hooksget_enhanced_conversions_data_from_sessionextract_user_data_from_session
Comment on lines
102
to
104
| if ( ! edd_is_success_page() ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Can we check if the function exists?
Suggested change
| if ( ! edd_is_success_page() ) { | |
| return; | |
| } | |
| if ( ! function_exists( 'edd_is_success_page' ) || ! edd_is_success_page() ) { | |
| return; | |
| } |
| return; | ||
| } | ||
|
|
||
| $purchase_session = edd_get_purchase_session(); |
There was a problem hiding this comment.
Same here. Let's check if the function exists.
Suggested change
| $purchase_session = edd_get_purchase_session(); | |
| if ( ! function_exists( 'edd_get_purchase_session' ) ) { | |
| return; | |
| } | |
| $purchase_session = edd_get_purchase_session(); |
| * | ||
| * @return array | ||
| */ | ||
| protected function get_enhanced_conversions_data_from_session( $session ) { |
There was a problem hiding this comment.
Suggested change
| protected function get_enhanced_conversions_data_from_session( $session ) { | |
| protected function get_enhanced_conversions_data_from_session( $session_data ) { |
| * @return array | ||
| */ | ||
| protected function get_enhanced_conversions_data_from_session( $session ) { | ||
| if ( ! is_array( $session ) ) { |
There was a problem hiding this comment.
Suggested change
| if ( ! is_array( $session ) ) { | |
| if ( ! is_array( $session_data ) ) { |
| return array(); | ||
| } | ||
|
|
||
| $user_data = $this->extract_user_data_from_session( $session ); |
There was a problem hiding this comment.
Suggested change
| $user_data = $this->extract_user_data_from_session( $session ); | |
| $user_data = $this->extract_user_data_from_session( $session_data ); |
Comment on lines
206
to
208
| // Attempt to get full region name. | ||
| $region = edd_get_state_name( $user_data['address']['country'], $region ); | ||
| $address_data['region'] = Enhanced_Conversions::get_normalized_value( $region ); |
There was a problem hiding this comment.
Let's check the edd_get_state_name function existence and have a fallback.
Suggested change
| // Attempt to get full region name. | |
| $region = edd_get_state_name( $user_data['address']['country'], $region ); | |
| $address_data['region'] = Enhanced_Conversions::get_normalized_value( $region ); | |
| // Attempt to retrieve the full region name if the EDD function exists and the country is available. | |
| if ( function_exists( 'edd_get_state_name' ) && ! empty( $country ) ) { | |
| $region = edd_get_state_name( $country, $region ); | |
| } | |
| $address_data['region'] = Enhanced_Conversions::get_normalized_value( $region ); |
Comment on lines
162
to
175
| $email = $session_info['email'] ?? $session['user_email']; | ||
| $first_name = $session_info['first_name']; | ||
| $last_name = $session_info['last_name']; | ||
|
|
||
| if ( isset( $session['user_info']['address'] ) ) { | ||
| $session_address = $session_info['address']; | ||
|
|
||
| $phone_number = $session_address['phone']; | ||
| $street = $session_address['line1']; | ||
| $city = $session_address['city']; | ||
| $region = $session_address['state']; | ||
| $postal_code = $session_address['zip']; | ||
| $country = $session_address['country']; | ||
| } |
There was a problem hiding this comment.
The variables are declared inside the if block. This causes "Undefined array key" errors when the if condition is false.
Either we should declare the variable early, or add null coalescing (??) fallbacks when extracting user data. This would have been evident with unit test coverage.
$email = $session_info['email'] ?? $session['user_email'] ?? '';
$first_name = $session_info['first_name'] ?? '';
$last_name = $session_info['last_name'] ?? '';
...There was a problem hiding this comment.
Good point. I tried adding null coalescing to all the variables at first but that increased the class complexity. I went with another (slightly more verbose) approach and just verify the existence (!empty) of every item in the $session_data array.
| * @var Easy_Digital_Downloads | ||
| */ | ||
| private $contactform; | ||
| private $edd; |
There was a problem hiding this comment.
Can we add unit test coverage for other methods as well?
|
Thanks for the review @hussain-t. I addressed your comments and improved the EDD class coverage. Please take another look. |
|
The pipeline failures seem unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist