Skip to content

Migrate storyshots to use test-runner and update storybook action. #11495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+1,763 −172
Open

Migrate storyshots to use test-runner and update storybook action. #11495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0874df
Migrate storyshots to use test-runner and update storybook action.
benbowler Sep 18, 2025
c2c2d75
Install Playwright browser in storybook action.
benbowler Sep 18, 2025
8bf60ea
Add valid locale to _googlesitekitLegacyData fixture.
benbowler Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/storybook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,17 @@
cache: npm
- name: npm install
run: npm i -w assets -w storybook -w tests/js --include-workspace-root
# TODO: #10473 will complete the migration to Storybook test-runner as storyshots is deprecated.
# - name: Test Storybook
# run: npm run test:storybook
- name: Install playwright browser
run: npx playwright install chromium
- name: Serve static Storybook
run: npx http-server ./dist -p 6006 &

- name: Wait for Storybook
run: |

Check warning on line 171 in .github/workflows/storybook.yml

View workflow job for this annotation

GitHub Actions / Lint Actions 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2034:warning:1:1: i appears unused. Verify use (or export if used externally) [shellcheck]

Raw Output:
w:.github/workflows/storybook.yml:171:9: shellcheck reported issue in this script: SC2034:warning:1:1: i appears unused. Verify use (or export if used externally) [shellcheck]
for i in {1..60}; do
curl -fsS http://localhost:6006/index.html && break
sleep 1
done

- name: Test Storybook
run: npm run test:storybook
Loading
Loading