Skip to content

Conversation

hussain-t
Copy link
Collaborator

@hussain-t hussain-t commented Sep 18, 2025

Summary

Addresses issue:

Relevant technical choices

Problem

  • Existing sites with GTG enabled were receiving isGTGDefault = true, making them eligible for opt-out notices, even though they had already chosen to enable GTG.

Solution

  • This follow-up PR adds logic to set isGTGDefault = false for existing sites where GTG was previously enabled.
  • This ensures opt-out notices only show to users who haven't explicitly interacted with GTG settings.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

…isting settings. This ensures appropriate default values are applied for new fields when GTG settings are present.
Copy link

github-actions bot commented Sep 18, 2025

Build files for b79cd7c are ready:

…g the `isGTGDefault` value based on existing settings.
…ethod to ensure correct default handling and enforce a one-way transition for `isGTGDefault` based on user interaction.
@nfmohit nfmohit marked this pull request as draft September 18, 2025 22:43
@nfmohit nfmohit changed the base branch from main to develop September 20, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant