Add force_implicit_token_calling_convention flag to dslx to ir converter #3076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdleary
approved these changes
Sep 18, 2025
| GetModuleMemberTypeName(*member.value()), node->identifier(), | ||
| node->span().ToString(file_table()))); | ||
| }}, | ||
| Visitor{[&](Function* f) { return DefAlias(f, /*to=*/node); }, |
There was a problem hiding this comment.
Did this change? hard to see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a flag to the DSLX-to-IR converter that forces all functions to use the implicit-token calling convention.
We need this to enable IR transformations that insert assertions into existing programs, which requires converting the function to the implicit-token convention.
Previously, this was impossible because the activation bit could not be inferred from the converted IR alone.
To support this behavior, we introduce a new flag that instructs the converter to generate implicit tokens for all functions.
This includes a breaking change to the C API to include the flag.