Simplify the creation of type variables in populate_table_visitor.cc #3094
+175
−399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_809151498
branch
2 times, most recently
from
e8d7829 to
c8aecb9
Compare
This buries the mechanics of creating type variables behind some helper functions without changing the logic, except that we now have more descriptive variable names generated. This change also exposed a type_info_to_proto test case with an internal variable erroneously in the output, which is fixed here. PiperOrigin-RevId: 809987690
copybara-service
bot
force-pushed
the
test_809151498
branch
from
c8aecb9 to
4276c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the creation of type variables in populate_table_visitor.cc
This buries the mechanics of creating type variables behind some helper functions without changing the logic, except that we now have more descriptive variable names generated.
This change also exposed a type_info_to_proto test case with an internal variable erroneously in the output, which is fixed here.