chore: remove non-existent files from legacy-librarian preserve regexes #15485
Conversation
The only README.txt file that exists is in packages/google-cloud-language. There are no README.rst files under samples directories.
Relatively few libraries actually have these directories; where they do, they have been left.
Summary of ChangesHello @jskeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively cleans up the .librarian/state.yaml file by removing references to non-existent files from the preserve_regex lists across numerous libraries. This aligns with the goal of simplifying migration and maintaining an accurate configuration. The changes are consistent across most libraries, primarily targeting samples/README.txt, samples/snippets/README.rst, and tests/system for removal from preserve_regex. There are also a few instances where README.rst was removed from remove_regex lists, which seems to be a related cleanup.
I am having trouble creating individual review comments. Click here to see my feedback.
.librarian/state.yaml (563-565)
In this section, samples/README.txt and samples/snippets/README.rst are removed from preserve_regex, which is consistent with the PR's goal of removing non-existent files. However, tests/system is also removed from this block (line 565) but then re-added at line 484 in the updated file. Could you clarify if tests/system was intended to be removed as a non-existent file, or if it should indeed be preserved and its re-addition is correct? The diff makes it appear as a move rather than a removal of a non-existent file.
| remove_regex: | ||
| - ^packages/google-cloud-audit-log/google/.*/.*(?:\.proto|_pb2\.(?:py|pyi))$ | ||
| - .repo-metadata.json | ||
| - README.rst |
There was a problem hiding this comment.
Will re-add this and the few other ones.
| - docs/automl_v1beta1/tables.rst | ||
| - google/cloud/automl_v1beta1/services/tables | ||
| - samples/README | ||
| - tests/system |
There was a problem hiding this comment.
This move is deliberate, to put all the entries in alphabetical order.
|
There's also an entry per library starting with |
|
For #15485 (comment), let's use a new PR. The files are handwritten, so we will want to preserve them, rather than delete them. |
I merged this PR because I am also planning to re-generate everything today as part of a gapic-generator update which only impacts |
2 participants
I'm currently regenerating everything to make sure this really doesn't remove anything it shouldn't (please don't merge until that's complete!) but this should make migration from legacy-librarian to librarian simpler, as librarian expects everything in its "keep" list to exist.