fix: prevent infinite loop on prune lineage #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| EndTime time.Time | ||
| } | ||
|
|
||
| func (r *LineageResolver) pruneLineage(lineage *scheduler.JobLineageSummary, maxUpstreamsPerLevel, depth int) *scheduler.JobLineageSummary { |
There was a problem hiding this comment.
Possible to cover this scenario in the test case
sravankorumilli
requested changes
Oct 17, 2025
deryrahman
reviewed
Oct 17, 2025
| func (r *LineageResolver) pruneLineage(lineage *scheduler.JobLineageSummary, maxUpstreamsPerLevel, depth int) *scheduler.JobLineageSummary { | ||
| // base case: stop if max depth reached or number of upstreams is already within limit | ||
| if depth > MaxLineageDepth || len(lineage.Upstreams) <= maxUpstreamsPerLevel { | ||
| if depth > MaxLineageDepth { |
There was a problem hiding this comment.
can we avoid to use function recursive? use stack data type instead
function recursive uses stack frame allocation, which is limited, and can lead to stack overflow. meanwhile using stack data type is more safe, as it uses heap memory
| // base case: stop if max depth reached or number of upstreams is already within limit | ||
| if depth > MaxLineageDepth || len(lineage.Upstreams) <= maxUpstreamsPerLevel { | ||
| if depth > MaxLineageDepth { | ||
| return &scheduler.JobLineageSummary{ |
There was a problem hiding this comment.
base question: why we need to prune the lineage? if cyclic is found, it's fine I guess as long as we don't revisit the job again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.