Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions mc2mc/internal/client/odps.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,12 @@ func (c *odpsClient) ExecSQL(ctx context.Context, query string, additionalHints
// wait execution success
select {
case <-ctx.Done():
c.logger.Info("context cancelled, terminating task instance")
err := c.terminate(taskIns)
return e.Join(ctx.Err(), err)
msg := "context canceled"
if err := context.Cause(ctx); err != nil {
msg = fmt.Sprintf("%s: %s", msg, err.Error())
}
c.logger.Info(msg)
return errors.WithStack(c.terminate(taskIns))
case err := <-c.wait(taskIns):
return errors.WithStack(err)
}
Expand Down
25 changes: 24 additions & 1 deletion mc2mc/mc2mc.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func mc2mc(envs []string) error {
}

// graceful shutdown
ctx, cancelFn := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGTERM)
ctx, cancelFn := signalAwareContext(context.Background(), os.Interrupt, syscall.SIGTERM)
defer cancelFn()

// initiate client
Expand Down Expand Up @@ -210,3 +210,26 @@ func execute(ctx context.Context, c *client.Client, queriesToExecute []string, a
}
return nil
}

// signalAwareContext creates a context that is aware of signals.
func signalAwareContext(parent context.Context, signals ...os.Signal) (context.Context, context.CancelFunc) {
ctx, cancelWithCause := context.WithCancelCause(parent)
sigCh := make(chan os.Signal, 1)
signal.Notify(sigCh, signals...)

// start a goroutine to handle signals
go func() {
select {
case sig := <-sigCh:
cancelWithCause(fmt.Errorf("signal: %v", sig))
signal.Stop(sigCh)
case <-ctx.Done():
signal.Stop(sigCh)
}
}()

// return a standard CancelFunc that preserves the original behavior
return ctx, func() {
cancelWithCause(context.Canceled)
}
}
Loading