Skip to content

Remove deprecated code #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Remove deprecated code #1408

wants to merge 16 commits into from
+311 −275

Conversation

@alyssajoyner
Copy link
Contributor

@alyssajoyner alyssajoyner commented Oct 21, 2025 •
edited
Loading

This PR removes deprecated code, components and styles.

Code

  • toBeCalledTimes is deprecated; replaced with toHaveBeenCalledTimes
  • toBeCalledWith is deprecated; replaced with toHaveBeenCalledWith
  • lightTheme is deprecated; replaced with theme
  • error is deprecated; replaced with errors
  • MutableDataFrame is deprecated; replaced with DataFrame
  • getDataProvider is deprecated; replaced with getSupplementaryQueryRequest
  • condition is deprecated

Components

  • HorizontalGroup and VerticalGroup are deprecated; replaced with Stack

Styles

  • Remove gf-form styles

NOTE: Select component is deprecated and should be replaced with Combobox. This work is not included in this PR due to testing issues with Combobox.

@alyssajoyner alyssajoyner self-assigned this Oct 21, 2025
@alyssajoyner alyssajoyner marked this pull request as ready for review October 21, 2025 21:21
@alyssajoyner alyssajoyner requested a review from a team as a code owner October 21, 2025 21:21
@alyssajoyner alyssajoyner moved this from Incoming to Needs Review in Partner Datasources Oct 21, 2025
@alyssajoyner alyssajoyner moved this from Needs Review to Incoming in Partner Datasources Oct 22, 2025
@alyssajoyner alyssajoyner marked this pull request as draft October 22, 2025 03:52
@adamyeats adamyeats moved this from Incoming to In Progress in Partner Datasources Oct 22, 2025
@alyssajoyner alyssajoyner moved this from In Progress to Needs Review in Partner Datasources Oct 23, 2025
@alyssajoyner alyssajoyner marked this pull request as ready for review October 23, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@aangelisc aangelisc Awaiting requested review from aangelisc aangelisc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

@zoesyc zoesyc Awaiting requested review from zoesyc zoesyc is a code owner automatically assigned from grafana/partner-datasources

At least 1 approving review is required to merge this pull request.

Assignees

@alyssajoyner alyssajoyner

Labels

None yet

Projects

Partner Datasources
Status: Needs Review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alyssajoyner