Skip to content

Conversation

@alyssajoyner
Copy link
Contributor

@alyssajoyner alyssajoyner commented Oct 21, 2025

This PR fixes a few small bugs on the config page:

  1. The LeftSidebar container showed a scrollbar at the bottom; overflow is now hidden
  2. Replace broken toggles: Validate Sql, TLS/SSL Settings Section, Secure connection and Enable Row limit with the correct function
  3. Changes the optional badge color from blue to darkgrey

@alyssajoyner alyssajoyner self-assigned this Oct 21, 2025
@alyssajoyner alyssajoyner requested a review from a team as a code owner October 21, 2025 21:23
@alyssajoyner alyssajoyner moved this from Incoming to Needs Review in Partner Datasources Oct 21, 2025
@alyssajoyner alyssajoyner changed the title Fix overflow and validate sql toggle bug Fix overflow and toggle bugs Oct 22, 2025
Copy link
Contributor

@adamyeats adamyeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes, but a few changes needed here!

Copy link
Contributor

@adamyeats adamyeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙌

@alyssajoyner alyssajoyner merged commit ea2e966 into main Oct 24, 2025
25 checks passed
@alyssajoyner alyssajoyner deleted the alyssa/config-bug-fixes branch October 24, 2025 20:23
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Partner Datasources Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants