-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[loki-distributed] Add index-gateway container lifecycle #3825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[loki-distributed] Add index-gateway container lifecycle #3825
Conversation
94aae2f
to
a5fd221
Compare
Signed-off-by: Francisco Robles Martín <[email protected]>
a5fd221
to
39abc48
Compare
@Sheikh-Abubaker @jkroepke I think the automatic reviewers assigned to the PRs are not active lately. May you review this small PR? |
I highly recommend migrate to the official loki helm chart. It doesnt get any updates any more, including app updates. |
Is it this one https://github.com/grafana/loki/tree/main/production/helm/loki? |
Yes! |
Cool! I will check to migrate to it. In the meantime, could this PR get reviewed? |
@jkroepke I was checking the loki Helm charts, and I see a bit of a mixed info there. Should I open a PR adding a note to all of them mentioning that they are not maintained anymore and to switch to the new one? For example:
|
@Jayclifford345 maybe you can give an better overview here. Generally, there is now an offical Loki Helm Chart, maintained by the Loki Team at https://github.com/grafana/loki This repository grafana/helm-charts is purely community driven. All charts here are mainly maintained by the community. Each chart have distinct maintainers. The conclusion is that the helm charts are maintained by inactive community members. Since everything is community driven here, there is no official commitment, including an official statement about the maintainer status. In reality, now that there is an official Loki chart, the community efforts in context of the mentioned Loki charts might stop completely. At the moment, some selected community member now helps the Loki team to maintain the chart. For record, this is just my point of view, as community maintainer for the Grafana Helm Chart here. |
We want to be able to set a
postStart
lifecycle in the index-gateways.The reason for it is that, with a few queries, the index-gateway pods run out of memory, and on top of setting a timeout for the queries (query_timeout), we also want to clean up the tsdb-cache folder on restarts of the pods.
Docs about this:
The same thing was done for the
ingester
at #2527