-
Notifications
You must be signed in to change notification settings - Fork 1.4k
browser: Implement unroute(url) and unrouteAll #5223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+325
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
reviewed
Oct 16, 2025
joanlopez
previously approved these changes
Oct 16, 2025
joanlopez
reviewed
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!! 🚀 I left a minor suggestion, but it's non-blocking at all.
mstoykov
approved these changes
Oct 16, 2025
joanlopez
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR implements two functions to remove routes that were added using the
page.route
function:page.unroute(url)
: removes the route(s) that match the same URL (url needs to be exactly what was used in theroute
function, it can't be a regex that matches the string used inroute
- this is the behavior of Playwright as well).page.unrouteAll()
: removes all routesNote:
unroute(url, handler)
as in PW will be way harder to implement in the k6 project because of the Sobek layer so this isn't included in this PR. We are waiting for strong interest from users before deciding to look into it.Why?
This allows users to reset the routes setup during a test or between tests if needed.
Checklist
make check
) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Closes #4501