Compiler: Support for stdin TypeScript source code #5246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
joanlopez
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
joanlopez
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
joanlopez
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
joanlopez
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
joanlopez
changed the title
joanlopez
requested review from
codebien,
mstoykov and
oleiade
and removed request for
a team
joanlopez
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
joanlopez
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
oleiade
previously approved these changes
Oct 20, 2025
mstoykov
reviewed
Oct 21, 2025
internal/js/compiler/compiler.go
Outdated
| return nil, "", err | ||
| } | ||
|
|
||
| if isTsExtensionFile { |
There was a problem hiding this comment.
I am not certain we should report the stdin parsing as well ... if we are going to do it.
I guess we can only report it past the StripTypes if the worry is that this might not work and we will report stuff more?
There was a problem hiding this comment.
I think the reason why I left it as-is is because I think it keeps the current behavior, on which we were only reporting usage when the file extension is indeed .ts.
But yeah, I agree that we could move that to once we have stripped types with no error (err == nil), so that way we would report it in both cases. Is that what you mean? Do you also think that would make sense?
If so, I'm happy to add that change here, before merging 👍🏻
mstoykov
previously approved these changes
Oct 21, 2025
joanlopez
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
joanlopez
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
mstoykov
approved these changes
Oct 21, 2025
codebien
approved these changes
Oct 21, 2025
oleiade
approved these changes
Oct 21, 2025
This was referenced Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Instead of stripping types (github.com/evanw/esbuild) only when the file extension is
.ts, it also does it (or tries to) when the script is provided directly through stdin (instead of file) and it cannot be parsed as JavaScript/ECMAScript source.Why?
Because currently, if the user provides TS source directly through stdin, k6 throws an error -the one it gets when trying to parse that code as JavaScript/ECMAScript source- and never tries to parse it as TS.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Closes #4773 and #5210