Skip to content

Conversation

@renovate-sh-app
Copy link
Contributor

@renovate-sh-app renovate-sh-app bot commented Oct 14, 2025

This PR contains the following updates:

Package Change Age Confidence
github.com/mailru/easyjson v0.9.0 -> v0.9.1 age confidence

Release Notes

mailru/easyjson (github.com/mailru/easyjson)

v0.9.1

Compare Source

What's Changed

New Contributors

Full Changelog: mailru/easyjson@v0.9.0...v0.9.1


Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@renovate-sh-app renovate-sh-app bot requested a review from a team as a code owner October 14, 2025 09:09
@renovate-sh-app renovate-sh-app bot requested review from codebien and joanlopez and removed request for a team October 14, 2025 09:09
@renovate-sh-app renovate-sh-app bot temporarily deployed to azure-trusted-signing October 14, 2025 09:15 Inactive
@renovate-sh-app renovate-sh-app bot temporarily deployed to azure-trusted-signing October 14, 2025 09:19 Inactive
@mstoykov mstoykov self-requested a review October 14, 2025 18:16
@mstoykov
Copy link
Contributor

Hmmm while no changes have happened to the actual libraries it seems, the code that generates stuff that we do not vendor is now generating slightl different code.

I wonder given that easyjson is likely a thing we will remove given json/v2 and the fact the the few uses it has currently are not actually that performance critical in the end. Maybe we should just close this and ignore this update while dropping easyjson usage.

One of that is on a public types, so we likely will need to keep it till v2.

@joanlopez
Copy link
Contributor

joanlopez commented Oct 15, 2025

One of that is on a public types, so we likely will need to keep it till v2.

If that's the case, isn't it better to merge this, considering it's a patch with apparently a couple of bug fixes? 🤔


Going further, do you want me to create a new issue to drop easyjson by v2 (I haven't found any yet), and add it to the list of things we plan to drop by v2?

Thanks!

@mstoykov
Copy link
Contributor

If that's the case, isn't it better to merge this, considering it's a patch with apparently a couple of bug fixes? 🤔

If we were hitting this issue - yes, but there are no indications of this. And now someone needs to go do this changes manually as renovate can not regenerate the code.

Going further, do you want me to create a new issue to drop easyjson by v2 (I haven't found any yet), and add it to the list of things we plan to drop by v2?

That might be a good idea. I intended to remove the cases where we do not use it after cdproto stopped using them, but have not gotten to it. Especially as tags are usign it in their public API, which is the v2 blocker.

| datasource | package                    | from   | to     |
| ---------- | -------------------------- | ------ | ------ |
| go         | github.com/mailru/easyjson | v0.9.0 | v0.9.1 |


Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
@renovate-sh-app renovate-sh-app bot force-pushed the renovate/github.com-mailru-easyjson-0.x branch from 94f25e7 to 42ff114 Compare October 15, 2025 09:03
@renovate-sh-app renovate-sh-app bot temporarily deployed to azure-trusted-signing October 15, 2025 09:09 Inactive
@renovate-sh-app renovate-sh-app bot temporarily deployed to azure-trusted-signing October 15, 2025 09:11 Inactive
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint issues 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants