-
Couldn't load subscription status.
- Fork 1.4k
fix(deps): update module github.com/mailru/easyjson to v0.9.1 #5269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hmmm while no changes have happened to the actual libraries it seems, the code that generates stuff that we do not vendor is now generating slightl different code. I wonder given that easyjson is likely a thing we will remove given json/v2 and the fact the the few uses it has currently are not actually that performance critical in the end. Maybe we should just close this and ignore this update while dropping easyjson usage. One of that is on a public types, so we likely will need to keep it till v2. |
If that's the case, isn't it better to merge this, considering it's a patch with apparently a couple of bug fixes? 🤔 Going further, do you want me to create a new issue to drop easyjson by v2 (I haven't found any yet), and add it to the list of things we plan to drop by v2? Thanks! |
If we were hitting this issue - yes, but there are no indications of this. And now someone needs to go do this changes manually as renovate can not regenerate the code.
That might be a good idea. I intended to remove the cases where we do not use it after cdproto stopped using them, but have not gotten to it. Especially as tags are usign it in their public API, which is the v2 blocker. |
| datasource | package | from | to | | ---------- | -------------------------- | ------ | ------ | | go | github.com/mailru/easyjson | v0.9.0 | v0.9.1 | Signed-off-by: renovate-sh-app[bot] <219655108+renovate-sh-app[bot]@users.noreply.github.com>
94f25e7 to
42ff114
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint issues 😕
This PR contains the following updates:
v0.9.0->v0.9.1Release Notes
mailru/easyjson (github.com/mailru/easyjson)
v0.9.1Compare Source
What's Changed
New Contributors
Full Changelog: mailru/easyjson@v0.9.0...v0.9.1
Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.