Skip to content

Move ConvertSelectOptionValues from browser to common #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2025
Merged

Move ConvertSelectOptionValues from browser to common #5302

merged 2 commits into from
Oct 23, 2025

Conversation

@ankur22
Copy link
Contributor

@ankur22 ankur22 commented Oct 14, 2025 •
edited
Loading

What?

Moving ConvertSelectOptionValues from browser to common.

Why?

It's mainly used in common, except for one test.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

#4220

@ankur22
Move ConvertSelectOptionValues to browser package
194a40a 
This removes the need to import Sobek in the element_handle.go file.
@ankur22
Remove unused function
a374d97
@ankur22 ankur22 added this to the v1.4.0 milestone Oct 14, 2025
@ankur22 ankur22 temporarily deployed to azure-trusted-signing October 14, 2025 10:17 — with GitHub Actions Inactive
@ankur22 ankur22 temporarily deployed to azure-trusted-signing October 14, 2025 10:19 — with GitHub Actions Inactive
@ankur22 ankur22 requested a review from inancgumus October 14, 2025 11:54
@ankur22 ankur22 marked this pull request as ready for review October 14, 2025 11:54
@ankur22 ankur22 requested a review from a team as a code owner October 14, 2025 11:54
@ankur22 ankur22 requested review from AgnesToulet and removed request for a team October 14, 2025 11:54
@inancgumus inancgumus mentioned this pull request Oct 20, 2025
Open
9 tasks
@ankur22 ankur22 merged commit a25013d into master Oct 23, 2025
46 of 47 checks passed
@ankur22 ankur22 deleted the refactor/elementHandle-remove-sobek branch October 23, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inancgumus inancgumus inancgumus approved these changes

@AgnesToulet AgnesToulet AgnesToulet approved these changes

Assignees

No one assigned

Labels

area: browser refactor

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ankur22 @inancgumus @AgnesToulet