Add Page.waitForEvent
#5315
Draft
Add Page.waitForEvent
#5315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It always uses Page and it doesn't make sense to keep it as a function. Plus, it's a Page behavior rather than a stand-alone functionality.
Changes: - Unexported: Not required except in the package. - This function doesn't only matches URLs, its usage is broad. So, it doesn't make sense to name it as URLMatcher.
And fix some naming inconsistencies throughout.
It's a duplication and replaced by RegExMatcher.
It's an unnecessary indirection for a single-line JS execution. We're also renaming related functions for consistency with RegExMatcher.
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
4 tasks
We'll use this method later for all page event handling methods, such as WaitForResponse and WaitForRequest. Implementing it also unlocks us to easily implement WaitForEvent in the future.
This functionality is a duplication of the existing page.on event system and complicates the page.on event handling system. Using the existing event handling system makes the code coherent with the existing and future functionality.
inancgumus
force-pushed
the
add/page-wait-for-event
branch
from
b5237f2 to
b736ccc
Compare
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
We no longer use events only for Page.On. Events are generic and belongs to a Page. So, they're now called just page events.
inancgumus
force-pushed
the
add/page-wait-for-event
branch
from
9bdc188 to
2d2008b
Compare
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
inancgumus
temporarily deployed
to
azure-trusted-signing
GitHub Actions
Inactive
inancgumus
force-pushed
the
refactor/pattern-matcher
branch
2 times, most recently
from
7f404c6 to
2b264b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Page.waitForEventfor waiting until aPageevent occurs.WaitForResponseto use the existingPageevent handling system.Why?
WaitForXmethods, such asWaitForEvent(with a capital W).Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Page.Onevent handling system forRequestandResponsehandling #5310Page.waitForRequest(urlOrPredicate[, options])#4483