fix(by copilot): stop escaping HTML in JSDoc strings#1284
Open
KnightNiwrem wants to merge 1 commit intomainfrom
Open
fix(by copilot): stop escaping HTML in JSDoc strings#1284KnightNiwrem wants to merge 1 commit intomainfrom
KnightNiwrem wants to merge 1 commit intomainfrom
Conversation
Remove the while loop in P.tsx that escaped <...> patterns to <...> in JSDoc text. This was breaking intentional HTML tags (like links) in JSDoc strings, causing broken links in the API reference. Fixes #1027 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the API reference generator’s paragraph renderer to stop escaping <...> patterns in JSDoc text so that intentional inline HTML (e.g. <a> links) survives into the generated reference pages, addressing broken links in the core API reference (Fixes #1027).
Changes:
- Removed the loop in
P.tsxthat escaped angle-bracket patterns outside code fences. - Kept the existing code-fence tweak (
```ts→```ts:no-line-numbers) and{@link ...}rewriting intact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KnorpelSenf
requested changes
Mar 5, 2026
Member
KnorpelSenf
left a comment
KnorpelSenf
left a comment
There was a problem hiding this comment.
This breaks the build for obvious reasons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM disclosure
Harness: Github Copilot CLI
Model: Claude Opus 4.6 (reasoning: high)
Remove the while loop in P.tsx that escaped <...> patterns to <...> in JSDoc text. This was breaking intentional HTML tags (like links) in JSDoc strings, causing broken links in the API reference.
Fixes #1027