support api 8 and up #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Would love to see this get merged. |
|
@grantland please merge the changes of @ndori |
|
Could someone confirm that this works on android-8? I would think it would crash when trying to load the class In addition, this needs to be rebased on |
| @Override | ||
| public void onLayoutChange(View view, int left, int top, int right, int bottom, | ||
| int oldLeft, int oldTop, int oldRight, int oldBottom) { | ||
| private AutofitSizeChangedListener sizeListener = new AutofitSizeChangedListener(); |
There was a problem hiding this comment.
nit: use hungarian notation to match the style in the rest of the file
There was a problem hiding this comment.
nit: also keep this up top with other ivars
|
Unfortunately it looks like this change will only allow usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently this library supports only api 14 and above (although it can actually support api 11 and above out of the box)
I've made a workaround for api that are lower than 11.