Skip to content

Conversation

andrerinaldi
Copy link

@andrerinaldi andrerinaldi commented Jun 29, 2017

I think the library is really useful... but inheriting from TextView limits its usages: extending from AppCompatTextView the AutoFitTextView can benefit of newer attributes for fonts (like app:fontFamily=“…”) and for tints (app:drawableTint="...").

In order to help developers avoid conflicts with the version of the support library they use in their apps, you could edit the readme.md specifying that the library should be imported excluding the support package like this:

dependencies {
    compile ('me.grantland:autofittextview:0.2.+') {
        exclude group:'com.android.support'
    }
}

Hope it helps! :)

… new features like app:fontFamily=“…”
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant