feat: migrate json-encoder-web from wasm-pack to direct wasm-bindgen #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace wasm-pack with direct wasm-bindgen CLI usage - Create build-wasm.js script to handle Rust compilation and bindings generation - Update webpack config to use native asyncWebAssembly support - Remove @wasm-tool/wasm-pack-plugin and wasm-loader dependencies - Update GitHub Actions CI to install Rust toolchain and wasm-bindgen - Add .gitignore for generated files (pkg/, dist/, target/) - Update import path in index.ts to match wasm-bindgen output This migration gives us more control over the build process and removes dependency on wasm-pack which had maintenance concerns. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
tmigone
previously approved these changes
Aug 4, 2025
tmigone
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the json-encoder-web build system from wasm-pack to using wasm-bindgen directly, addressing maintenance concerns with wasm-pack and giving us more control over the build process.
Changes
Build System Migration:
build-wasm.jsscript that directly callscargo buildandwasm-bindgen@wasm-tool/wasm-pack-pluginandwasm-loaderasyncWebAssemblysupportCI/CD Updates:
wasm32-unknown-unknowntargetwasm-bindgen-cliinstallation step (v0.2.100)Import Path Update:
'./pkg'to'./pkg/json_encoder_web'to match wasm-bindgen outputHousekeeping:
.gitignorefor generated files (pkg/,dist/,target/)Benefits
Testing
npm run build)npm run serve)Migration Notes
Developers will need to install:
rustup target add wasm32-unknown-unknown cargo install wasm-bindgen-cli --version "0.2.100"🤖 Generated with Claude Code