fix(scaffold): correct entity ID format in generated tests #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 882bfb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the PR! |
YaroShkvorets
approved these changes
Oct 25, 2025
When generating test files with --index-events, the entity ID format was
using the old string concatenation format ('-1') instead of the format
produced by concatI32() ('01000000'). This caused all generated tests to
fail out-of-the-box.
Changes:
- Update entity ID in test assertions from '-1' to '01000000' format
- Improve comment to explain concatI32() encoding with little-endian bytes
- Correct terminology from "default address" to "default transaction hash"
This fixes a bug introduced in commit 34aee49 (Oct 2022) when Bytes as ID
with @immutable was implemented. The mapping and schema templates were
updated but the test template was missed.
YaroShkvorets
force-pushed
the
feature/fix-scaffold-test-entity-id-format
branch
from
53180f8 to
882bfb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating test files with --index-events, the entity ID format was using the old string concatenation format ('-1') instead of the format produced by concatI32() ('01000000'). This caused all generated tests to fail out-of-the-box.
Changes:
This fixes a bug introduced in commit 34aee49 (Oct 2022) when Bytes as ID with @immutable was implemented. The mapping and schema templates were updated but the test template was missed.