Skip to content

Conversation

@Harshdev098
Copy link

fix: #617

Adds a pre-deployment check to warn users if subgraph contract addresses don’t exist on the target network.

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2025

🦋 Changeset detected

Latest commit: 39159cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphprotocol/graph-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Harshdev098
Copy link
Author

Hey @timmclean Can you please review it!

@YaroShkvorets
Copy link
Collaborator

I'll have a look

Copy link
Collaborator

@YaroShkvorets YaroShkvorets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things:

  1. sign the commits (this is a repo requirement): https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
  2. make it pass lint pnpm lint and tests pnpm test
  3. add minor-version changeset pnpm changeset

@Harshdev098 Harshdev098 force-pushed the patch-1 branch 2 times, most recently from 66aa0b3 to 0cae2ea Compare October 27, 2025 03:35
@Harshdev098
Copy link
Author

@YaroShkvorets Thanks! Have done the required changes

@YaroShkvorets
Copy link
Collaborator

Commit should have this "verified" badge.
image

@Harshdev098
Copy link
Author

But I have signedoff while amending the last commit @YaroShkvorets

@YaroShkvorets
Copy link
Collaborator

You haven't added GPG key to your GitHub account to make it verified: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@Harshdev098
Copy link
Author

@YaroShkvorets Yah have done it!

Copy link
Collaborator

@YaroShkvorets YaroShkvorets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach doesn't work.

You are querying Graph node JSON RPC endpoint for transaction count when you should be querying EVM chain JSON RPC instead. Graph node doesn't support eth_* methods.

Technically you can load the networks registry, get JSON RPC endpoint for that chain and try querying it. Just keep in mind that there could be dead ones, non-evm chains, and other edge cases you need to handle.

Also before submitting a PR it's a good idea to verify the fix works at least on a happy path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check if subgraph contract addresses are in blockchain

2 participants