Fix Issue #2276

.changeset/empty-horses-relate.md

@@ -0,0 +1,5 @@
+---
+'@graphql-eslint/eslint-plugin': patch
+---
+
+fix issue #2276

packages/plugin/__tests__/mocks/import-fragments/other-path/baz-fragment.gql

@@ -0,0 +1,3 @@
+fragment BazFields on Bar {
+  id
+}

packages/plugin/__tests__/mocks/import-fragments/valid-baz-query.gql

@@ -0,0 +1,9 @@
+# Imports could have extra whitespace and double/single quotes
+
+#  import  BazFields  from  ".\other-path\baz-fragment.gql"
+
+query {
+  baz {
+    ...BazFields
+  }
+}

packages/plugin/src/documents.ts

@@ -1,4 +1,4 @@
-import { resolve } from 'node:path';
+import path from 'node:path';
 import debugFactory from 'debug';
 import fg from 'fast-glob';
 import { GraphQLProjectConfig } from 'graphql-config';
@@ -21,7 +21,7 @@ const handleVirtualPath = (documents: Source[]): Source[] => {
     const index = (filepathMap[location] += 1);
     return {
       ...source,
-      location: resolve(location, `${index}_document.graphql`),
+      location: path.resolve(location, `${index}_document.graphql`),
     };
   });
 };

packages/plugin/src/rules/require-import-fragment/index.test.ts

@@ -3,7 +3,17 @@ import { CWD } from '@/utils.js';
 import { ParserOptionsForTests, ruleTester } from '../../../__tests__/test-utils.js';
 import { rule } from './index.js';
 
-function withMocks({ name, filename, errors }: { name: string; filename: string; errors?: any }) {
+function withMocks({
+  name,
+  filename,
+  errors,
+  only = false,
+}: {
+  name: string;
+  filename: string;
+  errors?: any;
+  only?: boolean;
+}) {
   return {
     name,
     filename,
@@ -14,10 +24,12 @@ function withMocks({ name, filename, errors }: { name: string; filename: string;
           filename,
           join(CWD, '__tests__', 'mocks', 'import-fragments', 'foo-fragment.gql'),
           join(CWD, '__tests__', 'mocks', 'import-fragments', 'bar-fragment.gql'),
+          join(CWD, '__tests__', 'mocks', 'import-fragments', 'other-path', 'baz-fragment.gql'),
         ],
       },
     } satisfies ParserOptionsForTests,
     errors,
+    only,
   };
 }
 
@@ -35,6 +47,10 @@ ruleTester.run('require-import-fragment', rule, {
       name: 'should not report fragments from the same file',
       filename: join(CWD, '__tests__', 'mocks', 'import-fragments', 'same-file.gql'),
     }),
+    withMocks({
+      name: 'should not report with correct relative path import',
+      filename: join(CWD, '__tests__', 'mocks', 'import-fragments', 'valid-baz-query.gql'),
+    }),
   ],
   invalid: [
     withMocks({

packages/plugin/src/rules/require-import-fragment/index.ts

@@ -90,13 +90,16 @@ export const rule: GraphQLESLintRule = {
           const extractedImportPath = comment.value.match(/(["'])((?:\1|.)*?)\1/)?.[2];
           if (!extractedImportPath) continue;
 
-          const importPath = path.join(path.dirname(filePath), extractedImportPath);
+          const importPath = path.join(
+            path.dirname(filePath),
+            extractedImportPath.replaceAll(/[/\\]/g, path.sep),
+          );
+
           const hasInSiblings = fragmentsFromSiblings.some(
             source => source.filePath === importPath,
           );
           if (hasInSiblings) return;
         }
-
         const fragmentInSameFile = fragmentsFromSiblings.some(
           source => source.filePath === filePath,
         );

packages/plugin/src/utils.ts

@@ -49,8 +49,7 @@ export const logger = {
 export const slash = (path: string): string => path.replaceAll('\\', '/');
 
 // Match slash or backslash for Windows
-// eslint-disable-next-line no-useless-escape
-export const VIRTUAL_DOCUMENT_REGEX = /[\/\\]\d+_document.graphql$/;
+export const VIRTUAL_DOCUMENT_REGEX = /[/\\]\d+_document.graphql$/;
 
 export const CWD = process.cwd();