Skip to content

Conversation

leebyron
Copy link
Collaborator

@leebyron leebyron commented Sep 1, 2025

prints to fit and removes descriptions since theyre not normative to keep this section easier to understand

Copy link

netlify bot commented Sep 1, 2025

Deploy Preview for graphql-spec-draft ready!

Name Link
🔨 Latest commit a2f1918
🔍 Latest deploy log https://app.netlify.com/projects/graphql-spec-draft/deploys/68b55049efdb2a00084e4d47
😎 Deploy Preview https://deploy-preview-1186--graphql-spec-draft.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@leebyron leebyron added the ✏️ Editorial PR is non-normative or does not influence implementation label Sep 1, 2025
@leebyron leebyron force-pushed the lee/appendix-spec-defs branch from a7b9141 to b25ae94 Compare September 1, 2025 07:45
@benjie
Copy link
Member

benjie commented Sep 1, 2025

I think one of Martin’s aims for this was to give example descriptions. I’m okay with removing them though.

) on SCALAR
directive @specifiedBy(url: String!) on SCALAR

directive @oneOf on INPUT_OBJECT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This snuck in ahead of that merge!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tee'ing it up

@leebyron leebyron merged commit 11c6664 into main Sep 1, 2025
9 checks passed
@leebyron leebyron deleted the lee/appendix-spec-defs branch September 1, 2025 08:49
@martinbonnin
Copy link
Contributor

I think one of Martin’s aims for this was to give example descriptions. I’m okay with removing them though.

Sorry I missed this. This was indeed the goal as different implementations have different descriptions and from personal experience, I would have loved some spec guidance around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editorial PR is non-normative or does not influence implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants