Fix includeDeprecated arg type in "Appendix D"
#1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
BoD
approved these changes
Sep 12, 2025
|
I believe Appendix D is produced by graphql.js, so this suggests that library has not caught up with this spec change. The PR should be directed there and then reflected here. |
|
@benjie nope, the #1142 references the correspondent PR in It's just not included to the |
|
At the time of writing the Appendix D. PR, I didn't find a version of graphql-js that matched exactly the spec draft so I had to tweak this manually. This must have been lost in translation somewhere. Thanks for fixing it @tyranron 🙏 |
martinbonnin
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1142
In #1142 the
includeDeprecatedarg's type was changed to non-Null, however its definition in the "Appendix D" wasn't changed, leading to confusions and misinterpretations.