Don't populate the domain field when heartbeating non-AD desktops #61490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The domain field doesn't cause any problems, since we ignore it when `ad: false`, but it's technically incorrect so we shouldn't be setting the field at all.
zmb3
added
no-changelog
danielashare
approved these changes
Nov 19, 2025
probakowski
approved these changes
Nov 19, 2025
Contributor
This was referenced Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The domain field doesn't cause any problems, since we ignore it when
ad: false, but it's technically incorrect so we shouldn't be setting the field at all.