Skip to content

fix: clean up resize observer #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2025
Merged

fix: clean up resize observer #461

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3a99bb
fix: clean up resize observer
DarkGenius Aug 24, 2025
3e2414d
Merge pull request #2 from DarkGenius/codex/find-and-fix-critical-cod…
DarkGenius Aug 24, 2025
6f132e3
Merge branch 'main' into main
DarkGenius Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/hooks/useOverflowingHorizontalListItems/useOverflowingHorizontalListItems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ export function useOverflowingHorizontalListItems<ItemType>({

useLayoutEffect(() => {
const footerMenu = containerRef.current;
if (!footerMenu) {
return;
}

const updateContainerSize = (entries: ResizeObserverEntry[]) => {
if (entries.length > 0 && footerMenu) {
Expand All @@ -49,7 +46,14 @@ export function useOverflowingHorizontalListItems<ItemType>({
const updateContainerSizeDebounced = debounceFn(updateContainerSize, 100);
const footerMenuResizeObserver = new ResizeObserver(updateContainerSizeDebounced);

footerMenuResizeObserver.observe(footerMenu);
if (footerMenu) {
footerMenuResizeObserver.observe(footerMenu);
}

return () => {
updateContainerSizeDebounced.cancel();
footerMenuResizeObserver.disconnect();
};
}, [containerRef]);

const isMeasured = containerWidth > 0;
Expand Down
Loading