Feat/css modules support #468
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated rollup.config.mjs to enable CSS modules with postcss plugin - Added TypeScript declarations for *.scss and *.css modules - Created createBlock utility function for CSS modules integration with BEM - Converted all 30+ components with styles to use CSS modules - Updated AsideHeader utils to use CSS modules - Fixed TypeScript signature compatibility issues - Maintained BEM naming convention with gn- namespace - CSS is now injected into JavaScript bundles - Build process successfully generates ESM and CJS outputs All components now support CSS modules while preserving existing API compatibility.
- Add null check in createBlock function for undefined styles object - Ensures components render with BEM class names when CSS modules aren't available - Fixes Storybook compatibility while maintaining CSS modules support in build
- Added null check in createBlock function to handle undefined styles object - Ensures compatibility between build (CSS modules) and Storybook (BEM fallback) - All components now render correctly in both environments
- Removed console.log statements from FooterItem component - Cleaned up Storybook webpack configuration
- Exclude Storybook log files from version control
- Renamed all component SCSS files from .scss to .module.scss - Updated all import statements to reference .module.scss files - Follows CSS modules naming convention for better clarity - All 32 component style files now use .module.scss extension - Rollup and Storybook configurations already support .module.scss files
- Renamed all component SCSS files from .scss to .module.scss - Updated all import statements to reference .module.scss files - Updated rollup configuration to handle .module.scss files specifically - Updated Storybook webpack configuration to handle both .module.scss and regular .scss files - Added storybook-static to .gitignore - Maintained backward compatibility for story files using regular .scss
- Simplified rollup config to use single input file with preserveModules - Rollup now automatically detects and splits components into separate JS files - Maintains clean directory structure with 140+ individual component files - Each component gets its own JS file while CSS is properly extracted - Supports both ESM and CJS builds with identical structure - Zero maintenance approach - new components automatically included Build results: - 140 JS files per build format (ESM/CJS) - 32 CSS modules as separate JS files - 149 TypeScript definition files - 1 consolidated CSS file with all component styles
- Map multi-class tokens in cn utility - Fix MultipleTooltip CSS and transparency - Use object classNames in Drawer transitions - Adjust rollup extractComponentCss plugin and tests - Update test Next.js app and checklist
- Map multi-class tokens in cn utility - Fix MultipleTooltip CSS and transparency - Use object classNames in Drawer transitions - Adjust rollup extractComponentCss plugin and tests - Update test Next.js app and checklist
- Map multi-class tokens in cn utility - Fix MultipleTooltip CSS and transparency - Use object classNames in Drawer transitions - Adjust rollup extractComponentCss plugin and tests - Update test Next.js app and checklist
DarkGenius
requested review from
BlackPoretsky,
Lunory and
kendoow
as code owners
|
Preview is ready. |
|
Playwright Test Component is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.