fix: fixed exports format for package #25
Merged
+83
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added conditional exports as modern approach Restrited interface to index files only for each lib part Removed config examples as non-relevant content Ported patch for collectPageActivity action from playwright-utils
Avol-V
approved these changes
Nov 26, 2025
| "./actions": { | ||
| "types": "./actions/index.d.ts", | ||
| "import": "./actions/index.js", | ||
| "require": "./actions/index.js" |
There was a problem hiding this comment.
Maybe we can just use default here, instead of import+require with the same target?
"default" - the generic fallback that always matches. Can be a CommonJS or ES module file. This condition should always come last.
Collaborator
Author
There was a problem hiding this comment.
Hmm, lets keep it as is. If sometime later we will need to separate commonjs and module APIs, we will need to go back to this place.
Some verbosity here is ok IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added conditional exports as modern approach
Restrited interface to index files only for each lib part Removed config examples as non-relevant content
Ported patch for collectPageActivity action from playwright-utils