Fix: Replace deprecated dbapi() with import_dbapi() in dialect classes#10
Open
leodrivera wants to merge 1 commit intogreat-expectations:mainfrom
Open
Fix: Replace deprecated dbapi() with import_dbapi() in dialect classes#10leodrivera wants to merge 1 commit intogreat-expectations:mainfrom
leodrivera wants to merge 1 commit intogreat-expectations:mainfrom
Conversation
SQLAlchemy has deprecated the dbapi() classmethod in favor of import_dbapi(). This change updates both dialect classes to use the new method name, eliminating the SADeprecationWarning. Fixes: great-expectations/great_expectations#11141 Changes: - Rename dbapi() to import_dbapi() in Psycopg2RedshiftDialectMixin - Rename dbapi() to import_dbapi() in RedshiftDialect_redshift_connector - Add docstrings to both import_dbapi() methods explaining their purpose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a deprecation warning by replacing the deprecated
dbapi()classmethod withimport_dbapi()in both Redshift dialect classes. SQLAlchemy has deprecateddbapi()in favor ofimport_dbapi()to better reflect the method's purpose.Problem
When using this library with SQLAlchemy, users encounter the following deprecation warning:
This was reported in: great-expectations/great_expectations#11141
Solution
dbapi()toimport_dbapi()inPsycopg2RedshiftDialectMixindbapi()toimport_dbapi()inRedshiftDialect_redshift_connectorimport_dbapi()methods explaining their purposeChanges
sqlalchemy_redshift/dialect.py: Updated both dialect classes to useimport_dbapi()instead ofdbapi()