-
Notifications
You must be signed in to change notification settings - Fork 4
Hdg wave #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davelee2804
wants to merge
67
commits into
master
Choose a base branch
from
hdg_wave
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hdg wave #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GridapHybrid and related version of Gridap)
GridapHybrid versions
the assembly terms
the HDG advection assembly
…:gridapapps/GridapGeosciences.jl into hdg_adv Conflicts: Project.toml
not crash). The current results it is generating are wrong.
owner normal in the advection equation. results look more coherant, but still oscillatory
figure out how to implement the jump() operator...
marginally improved
also removing the (n.n) terms. results greatly improved
representative of the original error
the normal and radial vectors
for the tangent vector jump penalisation
adding alternative solve including the pressure gradient tangnet in the 4th equation, and also additing a diagnostic for the vorticity
fixing some minor bugs
the previons time step
and also doing a cleanup
order integrator for testing, (3) doing the nonlinear terms explicitly
that the advection equation can be split into its linear and nonlinear parts for use with the IMEX integrator, and also adding IMEX(2,3,2) time stepping (+bug fix)
not sure about the lagrange multiplier equation however...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for the development of a wave equation solved on the cubed sphere using GridapHybrid on H1 elements. The wider goal is to use the Lagrange multipliers of the skeleton to enforce both mass conservation and zero spurious vorticity generation, as per the attached document
hdg_wave_eqn.pdf