Add rabbitmq consumer AutoConfiguration for consumeRun queues priority#35
Open
klesaulnier wants to merge 3 commits intomainfrom
Open
Add rabbitmq consumer AutoConfiguration for consumeRun queues priority#35klesaulnier wants to merge 3 commits intomainfrom
klesaulnier wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
|
antoinebhs
reviewed
Mar 18, 2026
|
|
||
| @AutoConfiguration | ||
| @ConditionalOnProperty( | ||
| name = "computation.rabbit.consume-run-load-balanced.enabled", |
Contributor
There was a problem hiding this comment.
I'm not sure about the intent of this?
If it's not used in our services and true by default?
antoinebhs
reviewed
Mar 18, 2026
| matchIfMissing = true | ||
| ) | ||
| public class RabbitConsumerAutoConfiguration { | ||
| private static final String RABBITMQ_CONSUMER_NAME_TO_LOAD_BALANCE = "consumeRun1-in-0"; |
Contributor
There was a problem hiding this comment.
We expect all computation servers to use this consumer name, right?
antoinebhs
reviewed
Mar 18, 2026
Contributor
antoinebhs
left a comment
antoinebhs
left a comment
There was a problem hiding this comment.
Some comments to discuss?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary