Conversation
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
📝 WalkthroughWalkthroughTwo new data structures were added to support line segment information in line creation modifications. A new Changes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/main/java/org/gridsuite/modification/dto/LineCreationInfos.java`:
- Around line 50-51: The new DTO field lineSegments
(LineCreationInfos.lineSegments / getLineSegments()) is accepted but never used
in LineCreation.check() or LineCreation.apply(), causing a silent no-op; add a
fail-fast validation in LineCreation.check() that detects a non-null/non-empty
dto.getLineSegments() and throws a clear validation exception (or
IllegalArgumentException/ValidationException consistent with existing error
handling) stating that lineSegments is not yet supported, so callers receive an
immediate, descriptive error instead of the field being ignored.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f034b298-8b98-46f7-83b8-6477b1c9c752
📒 Files selected for processing (2)
src/main/java/org/gridsuite/modification/dto/LineCreationInfos.javasrc/main/java/org/gridsuite/modification/dto/LineSegmentInfos.java



PR Summary
Add Line segments infos to line creation infos