-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[issue-6080] Fix strict no-$ref-siblings rule violations
#6099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Julien Greffe <[email protected]>
| } | ||
| } | ||
|
|
||
| func TestArrayMessageItemsTypeOmitWhenRefSibling(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost the same test as TestArrayMessageItemsType, but we check we don't have results like these.
johanbrandhorst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Could you please add a section to our docs for this new option? https://github.com/grpc-ecosystem/grpc-gateway/blob/main/docs/docs/mapping/customizing_openapi_output.md is usually used for options.
Also, since this is a new option, we need to add support for it to our Bazel definitions. Please see existing patterns for options in https://github.com/grpc-ecosystem/grpc-gateway/blob/main/protoc-gen-openapiv2/defs.bzl and add this option. Thanks!
Signed-off-by: Julien Greffe <[email protected]>
johanbrandhorst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you!
|
Looks like a minor formatting issue in the bazel file, I would ignore the fuzz error |
Signed-off-by: Julien Greffe <[email protected]>
Head branch was pushed to by a user without write access
|
Thanks for your contribution! |
References to other Issues or PRs
Fixes #6080
Have you read the Contributing Guidelines?
Brief description of what is fixed or changed
Introduce a new option
omit_array_item_type_when_ref_siblingwhich allows to omit atype: objectif a$refalready exists.This fixes strict
no-$ref-siblingsrule violations.But default this option is
falseto keep previous behavior.Other comments