Skip to content

Align default keepAlive with gRPC defaults #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

Align default keepAlive with gRPC defaults #550

merged 1 commit into from
May 25, 2021

Conversation

cfredri4
Copy link
Contributor

This changes:

  • default keepAliveTime on server to 2 hours (to align with gRPC default)
  • default keepAliveTime on client to 5 minutes to align with default permitKeepAliveTime on server (cannot be lower)

@cfredri4
Align default keepAlive with gRPC defaults
bdd82e3 
This changes:
* default keepAliveTime on server to 2 hours (to align with gRPC default)
* default keepAliveTime on client to 5 minutes to align with default permitKeepAliveTime on server (cannot be lower)
@ST-DDT ST-DDT self-assigned this May 25, 2021
@ST-DDT ST-DDT added the enhancement A feature request or improvement label May 25, 2021
@ST-DDT ST-DDT added this to the 2.13.0 milestone May 25, 2021
@ST-DDT ST-DDT self-requested a review May 25, 2021 11:36
@ST-DDT
Copy link
Collaborator

ST-DDT commented May 25, 2021

Looks good to me. Thanks for your contribution.
Could you please add a link to the source of your information regarding the defaults?
I would like to reference it in the changelog

@cfredri4
Copy link
Contributor Author

Looks good to me. Thanks for your contribution.
Could you please add a link to the source of your information regarding the defaults?
I would like to reference it in the changelog

io.grpc.netty.NettyServerBuilder defines:
private long permitKeepAliveTimeInNanos = TimeUnit.MINUTES.toNanos(5);

io.grpc.internal.GrpcUtil defines:
public static final long DEFAULT_SERVER_KEEPALIVE_TIME_NANOS = TimeUnit.HOURS.toNanos(2L);

@ST-DDT ST-DDT merged commit 9358508 into grpc-ecosystem:master May 25, 2021
@cfredri4 cfredri4 deleted the align-default-keepalive-with-grpc-defaults branch May 26, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@ST-DDT ST-DDT

Labels
enhancement A feature request or improvement
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cfredri4 @ST-DDT