Skip to content

Conversation

a-simeshin
Copy link
Contributor

Context

It seems to me that the client configuration page in the part of interceptors should contain examples with client, not server examples. Also, there is a mention of the GlobalClientInterceptorConfigurer in the documentation, but no example.

What is done

  • Example with LogServerInterceptor changed to LogClientInterceptor with correct annotations in the client documentation
  • Added example with GlobalClientInterceptorConfigurer to the client documentation

…dd usage example for GlobalClientInterceptorConfigurer
Copy link
Collaborator

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this issue.
I put quite some effort into the docs, so it's good to know that there are people out there who read the docs careful enough to spot these errors.

@ST-DDT ST-DDT added the documentation Everything related to the documentation label Sep 2, 2021
@ST-DDT ST-DDT self-assigned this Sep 2, 2021
@ST-DDT ST-DDT added this to the 2.13.0 milestone Sep 2, 2021
@ST-DDT ST-DDT merged commit 3dd7f2c into grpc-ecosystem:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Everything related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants