Skip to content

Enhance error handling to support streaming calls #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2021
Merged

Enhance error handling to support streaming calls #586

merged 3 commits into from
Sep 24, 2021

Conversation

ST-DDT
Copy link
Collaborator

@ST-DDT ST-DDT commented Sep 19, 2021

Fixes #516
Fixes #561

Now it is possible to use the server side exception handling in all circumstances.

  • Grpc service method itself
  • Response StreamObserver#onError
  • Request StreamObserver#onNext
  • Request StreamObserver#onComplete

@ST-DDT ST-DDT added the enhancement A feature request or improvement label Sep 19, 2021
@ST-DDT ST-DDT added this to the 2.13.0 milestone Sep 19, 2021
@ST-DDT ST-DDT requested a review from yidongnan September 19, 2021 15:07
@ST-DDT ST-DDT self-assigned this Sep 19, 2021
This was referenced Sep 19, 2021
Closed
Closed
@yidongnan yidongnan merged commit 1f76160 into master Sep 24, 2021
@yidongnan yidongnan deleted the feature/streaming-exception-handling branch September 24, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yidongnan yidongnan yidongnan approved these changes

Assignees

@ST-DDT ST-DDT

Labels
enhancement A feature request or improvement
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

GrpcExceptionHandler supports clientStreaming usecase Advice exception handling not working with grpc-kotlin coroutines
2 participants
@ST-DDT @yidongnan