Improve authentication capabilities #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add overwritable hook methods - onSuccessfulAuthentication(...) - onUnsuccessfulAuthentication(...) - Restore the full SecurityContext instead of just the Authentication - This allows storing additional information in the context, - and additional features such as changes to the currently active authentication (Login As X)
ST-DDT
force-pushed
the
feature/security-api-refactor
branch
from
ba4f2f4 to
72c249f
Compare
yidongnan
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the authentication process in the following fashion:
SECURITY_CONTEXT_KEYthat now stores the entire security context instead of just the authentication, the security context is able to store more than just the authentication and can be used to replace the authentication during a call (e.g. for impersonation by admins or changing the roles of the user on the fly)SecurityContextto the grpcContextAUTHENTICATION_CONTEXT_KEYin favor ofSECURITY_CONTEXT_KEY