Skip to content

Improve DiscoveryClientNameResolver implementation #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2021
Merged

Improve DiscoveryClientNameResolver implementation #600

merged 2 commits into from
Nov 22, 2021

Conversation

ST-DDT
Copy link
Collaborator

@ST-DDT ST-DDT commented Nov 20, 2021

@ST-DDT ST-DDT added the enhancement A feature request or improvement label Nov 20, 2021
@ST-DDT ST-DDT added this to the 2.13.0 milestone Nov 20, 2021
@ST-DDT ST-DDT requested a review from yidongnan November 20, 2021 20:39
@ST-DDT ST-DDT self-assigned this Nov 20, 2021
@ST-DDT ST-DDT mentioned this pull request Nov 20, 2021
Closed
yidongnan
yidongnan approved these changes Nov 22, 2021
View reviewed changes
Copy link
Collaborator

@yidongnan yidongnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yidongnan yidongnan merged commit 080ca42 into master Nov 22, 2021
@yidongnan yidongnan deleted the refactor/discovery branch November 22, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yidongnan yidongnan yidongnan approved these changes

Assignees

@ST-DDT ST-DDT

Labels
enhancement A feature request or improvement
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Add ServiceInstance.metadata to EquivalentAddressGroup.attributes
2 participants
@ST-DDT @yidongnan