-
Notifications
You must be signed in to change notification settings - Fork 19
Feat: Added Project Groups API & Add Test Run Status Tracking #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: Added Project Groups API & Add Test Run Status Tracking #267
Conversation
f347be7 to
6434569
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new status column to the test_runs table and wires it through the model, data migration, handlers, and tests to support filtering, sorting, and preloading in the GET /api/testruns endpoint.
- Introduce
statusfield inTestRunmodel along with a migration and backfill routine. - Enhance GET
/api/testrunsto supportproject_uuid,sort_by,order, andfieldsparameters. - Update handler logic, utilities, and tests to compute and include
statusvalues.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/models/types.go | Added Status field to TestRun model |
| pkg/db/migrations/000009_alter_test_runs_table.up.sql | Altered test_runs table to add status column |
| pkg/datamigrations/status_backfill.go | Backfill script to compute and populate status for existing rows |
| pkg/api/handlers/handlers.go | Compute status on create and extend GET /testruns handler for filters, sorting, and preloads |
| pkg/api/handlers/handlers_test.go | Added tests for invalid parameters, project_uuid filter, sorting, preloading, and updated INSERT expectations |
| pkg/api/handlers/handler_utils.go | Updated summary query to use case-insensitive status filters |
| main.go | Kick off asynchronous BackfillTestRunStatus on startup |
Comments suppressed due to low confidence (1)
pkg/api/handlers/handlers.go:175
- You call log.Println() in the GET handler but
logis not imported, causing a compile error. Please addimport "log"at the top of the file.
log.Println()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic found 6 issues across 7 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic found 5 issues across 7 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
|
@saini-prakhyat : was experimenting with multiple AI tools, so you would have got reviews from copilot and cubic. I believe both are valid |
Kusari Analysis ResultsAnalysis for commit: dd4e183, performed at: 2025-06-13T15:35:26Z • • Recommendation✅ PROCEED with this Pull Request Summary✅ No Flagged Issues Detected All values appear to be within acceptable risk parameters. No pinned version dependency changes, code issues or exposed secrets detected! Found this helpful? Give it a 👍 or 👎 reaction! |
|
Kusari PR Analysis rerun based on - 17d8b53 performed at: 2025-06-13T15:35:26Z - link to updated analysis |
|
Kusari PR Analysis rerun based on - 0cf1cb0 performed at: 2025-06-21T12:43:57Z - link to updated analysis |
…into feat/test-run-filter
|
Kusari PR Analysis rerun based on - 8985e06 performed at: 2025-06-22T14:49:02Z - link to updated analysis |
|
Kusari PR Analysis rerun based on - 57eda5f performed at: 2025-06-22T17:00:17Z - link to updated analysis |
|
Kusari PR Analysis rerun based on - 9880126 performed at: 2025-06-22T17:07:15Z - link to updated analysis |
|
Kusari PR Analysis rerun based on - dd4e183 performed at: 2025-06-28T08:37:24Z - link to updated analysis |
For issue : #255
Overview
This PR finalizes the Project Groups API and test run status tracking, ensuring robust integration, clean routing, and comprehensive test coverage.
Key Changes