Refactor last commit retrieval to use a non deprecated method #4898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the code to consolidate duplicate logic for fetching repository commit information. The main change replaces direct calls to repository_object.set_last_commit() with a new method async_set_last_commits() that uses the GitHub REST API to fetch branch information.
- Introduces a new method
async_set_last_commits()that fetches the last commit SHA from the repository's default branch - Replaces two instances of duplicated commit-fetching code with calls to the new method
- Changes the implementation from using
repository_object.set_last_commit()to directly calling the GitHub API
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entire repository_object is deprecated in aiogithubapi; this is a small step in getting rid of it.