Fix memory access type flags in featurization #8693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The is_transpose flag should satisfy: single one per row AND single one per column. And for is_broadcast it should be: single one per row AND (single one OR all zeros) per column.
|
As I stated in the issue, this would invalidate the pretrained cost model. I think the simplest fix is to start from this PR and also swap the order of transpose_accesses and broadcast_accesses in struct PipelineFeatures in Featurization.h That would be equivalent to just renaming some things. |
|
Thanks for fixing this, by the way! |
|
Yes I agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8692