Fix lowering of pow() in D3D12Compute when the base is provably positive #8813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an internal report of a codegen error when lowering
pow()
in the D3D12Compute backend, producing incorrect HLSL like the following:pow(_183, float _367 = _364 * _364;
The root issue was that this lowering path was directly injecting into the string representing the shader, rather than using a lowering path that will handle dealing with the arguments correctly. Also added a test that failed before this change; I can separate it out to its own file if that's better.