[Envoy Bootstrap] Defaults to IPv6 for admin-bind and grpc-addr in dual stack #22757
+1,328
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded `github.com/miekg/dns` dependency to v1.1.68. - Included `BindAddr` in agent endpoint and enabled binding logic in IP offset calculations. - Updated `go.mod` and `go.sum` to reflect dependency changes.
…ntBindAddr` for improved binding logic and IP offset calculation. Added utility function isDualStack
…log.go` to use new functions for improved modularity and clarity. Removed duplicate implementations of `GetAgentConfig` and `isDualStack`.
…ntConfig`, `GetAgentBindAddr`, and `IsDualStack`. Refactored functions to support mocking for improved testability.
github-actions
bot
added
the
theme/cli
yaminisridaran
requested changes
Sep 15, 2025
There was a problem hiding this comment.
@anilvpatel I have provided my review comments below. Please address the comments.
| // everywhere which might make this test brittle but not sure what else | ||
| // to do. | ||
| GRPC: GRPC{ | ||
| AgentAddress: "127.0.0.1", |
There was a problem hiding this comment.
@anilvpatel please consider using constant instead of hardcode values in multiple places.
There was a problem hiding this comment.
Constants help maintainability, but for expected test values, keeping them visible as-is improves clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When no explicit flags are provided, Envoy should default to 127.0.0.1 in IPv4-only environments and ::1 in IPv6/Dual Stack environment determine based on the local agent bind_addr.
PR Checklist